Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new sandstone storage backend implementation to Sunbeam and integrates it into the unit test suite so it participates in the shared backend interface/uniqueness checks.
Changes:
- Introduce
SandstoneBackend+SandstoneConfigundersunbeam.storage.backends.sandstone. - Register the new backend in test fixtures and common backend uniqueness/expectation tests.
- Add backend-specific unit tests for the sandstone backend and its config validation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/sandstone/backend.py |
Adds the Sandstone backend class and its Pydantic config model. |
sunbeam-python/sunbeam/storage/backends/sandstone/__init__.py |
Introduces the sandstone backend package. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds a sandstone_backend fixture and includes sandstone in the parametrized any_backend fixture. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extends shared “unique types/charm names” and expected-values tests to include sandstone. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_sandstone.py |
Adds backend-specific tests for sandstone metadata and protocol validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Optional backend configuration | ||
| default_sandstone_target_ips: Annotated[ | ||
| str | None, | ||
| Field(description="SandStone default target ip."), |
Author
There was a problem hiding this comment.
Assisted-by: Claude sonnet 4.6
ahmad-can
force-pushed
the
feature/generate-sandstone-charm
branch
from
a0960a8 to
a113a12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984520